accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1757) Create BatchDeleter with a provided BatchWriter instead of creating a new one
Date Mon, 07 Oct 2013 22:29:43 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788651#comment-13788651
] 

Keith Turner commented on ACCUMULO-1757:
----------------------------------------

I was thinking about what the API change look like.  Below is a possibility.  It seems like
you want the user to be able to pass a BatchWriterConfig XOR a BatchWriter.

{code:java}
class BatchDeleterConfig {
  public BatchDeleterConfig(BatchWriterConfig bwc){}
  public BatchDeleterConfig(BatchWriter bw){}
  public void setNumQueryThreads();
}

class Connector {
  ...
  public abstract BatchDeleter createBatchDeleter(String tableName, Authorizations authorizations,
BatchDeleterConfig config)
  ...
}
{code}

Wouldn't you also want the ability to pass in a batch reader?   The API above does not include
that.   Another approach may be allowing users to pass in a thread pool like ACCUMULO-1224

> Create BatchDeleter with a provided BatchWriter instead of creating a new one
> -----------------------------------------------------------------------------
>
>                 Key: ACCUMULO-1757
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1757
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>            Reporter: John Vines
>            Priority: Minor
>             Fix For: 1.6.0
>
>
> For the BatchDeleter, you pass it all the configs you need to create both a Scanner and
a BatchWriter for it to provide really convenient deletes. However, if a client already has
a BatchWriter, it would be convenient to just hand it an existing BatchWriter to use instead
of creating a separate one.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message