accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Vines (JIRA)" <>
Subject [jira] [Updated] (ACCUMULO-1703) Thrift generated code isn't properly checked for optional fields
Date Wed, 30 Oct 2013 22:54:25 GMT


John Vines updated ACCUMULO-1703:

    Fix Version/s:     (was: 1.6.0)

I don't see this making 1.6

> Thrift generated code isn't properly checked for optional fields
> ----------------------------------------------------------------
>                 Key: ACCUMULO-1703
>                 URL:
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Christopher Tubbs
>            Priority: Minor
>             Fix For: 1.7.0
> In our thrift definition files, we declare some fields as optional. However, we don't
actually check to see if they are sent. This may be okay for Objects, which we can check for
null, but it won't work for checking optional primitives.
> Example:
> ProxyServer.createBatchScanner() accepts a BatchScanOptions object, which has the number
of threads as an optional parameter. Instead of calling opts.threads, we should check if opts.isSetThreads()
is true, and then retrieve it with opts.getThreads().
> This is an essential check for all optional arguments (non-optional args are validated
by the generated validate() method).
> The importance of the optional field is high, if we want to support RPC compatibility
across versions. As far as I know, this is one of the goals of the client proxy. So, we must
use the thrift features (such as the optional flag) correctly.

This message was sent by Atlassian JIRA

View raw message