accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-391) Multi-table Accumulo input format
Date Tue, 01 Oct 2013 18:14:26 GMT


Josh Elser commented on ACCUMULO-391:

Looks good to me. Nitpicking: can you run the formatter over TableQueryConfig and InputConfigurator
before pulling into master? It looked like those were still a little goofy.

A broader general question: InputFormatBase (mapred and mapreduce) both have a protected static
method getTabletLocator method that is tagged with a {{@since 1.5.0}} whose signature was
changed with these changes. Do we just update the javadoc from since 1.5.0 to 1.6.0 because
it wasn't a part of the "public API"? Do we have any general practice for javadoc tags on
internal API changes?

> Multi-table Accumulo input format
> ---------------------------------
>                 Key: ACCUMULO-391
>                 URL:
>             Project: Accumulo
>          Issue Type: New Feature
>            Reporter: John Vines
>            Assignee: Corey J. Nolet
>            Priority: Minor
>              Labels: mapreduce,
>             Fix For: 1.6.0
>         Attachments: ACCUMULO-391.patch, multi-table-if.patch, new-multitable-if.patch
> Just realized we had no MR input method which supports multiple Tables for an input format.
I would see it making the table the mapper's key and making the Key/Value a tuple, or alternatively
have the Table/Key be the key tuple and stick with Values being the value.

This message was sent by Atlassian JIRA

View raw message