Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Fri, 6 Sep 2013 01:46:52 +0000 (UTC)
From: "Christopher Tubbs (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12667239.1378428890086.89321.1378432012291@arcas>
In-Reply-To: <JIRA.12667239.1378428890086@arcas>
References: <JIRA.12667239.1378428890086@arcas>
Subject: [jira] [Commented] (ACCUMULO-1691) Update thrift to 0.9.1 / clean
 up TServerUtils
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13759757#comment-13759757 ] 

Christopher Tubbs commented on ACCUMULO-1691:
---------------------------------------------

I ran into a problem updating thrift to 0.9.1. It seems that in TServerUtils, we extend THsHaServer so we can override the Invocation class, for the sole purpose of setting the clientAddress with the socket info from the frameBuffer's transport.

This actually seems completely unnecessary, because we can get this information from our ClientInfoProcessorFactory. However, we don't seem to be using that at all... as it is only called in the TServerUtils.startThreadPoolServer, which doesn't appear to ever be called.

It feels like we're shooting ourselves in the foot with some of this TServerUtils stuff.
                
> Update thrift to 0.9.1 / clean up TServerUtils
> ----------------------------------------------
>
>                 Key: ACCUMULO-1691
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1691
>             Project: Accumulo
>          Issue Type: Task
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>            Priority: Minor
>             Fix For: 1.6.0
>
>
> Updating to thrift 0.9.1 fixes some bugs in code generation, among other things.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira