accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1627) Add hashcode() and equals() to ConditionalMutation
Date Mon, 30 Sep 2013 15:34:28 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781938#comment-13781938
] 

Keith Turner commented on ACCUMULO-1627:
----------------------------------------

bq. That's a cool workaround. 

Hopefully we can get the behavior we want (except for Liskov substitution principle, but I
agree that does not seem important ) w/ equals w/o changing the API. It may be useful to put
a comment mentioning Mutation.equals(Mutation) is intentionally screwy w/ a reference to the
ticket. Someone taking a fresh look at the code would not understand why the method even exists.
  Going forward we should probably avoid adding non equals(Object) methods.  This will be
something to check for when reviewing API changes for 1.6.0.

> Add hashcode() and equals() to ConditionalMutation
> --------------------------------------------------
>
>                 Key: ACCUMULO-1627
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1627
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: client, tserver
>            Reporter: Keith Turner
>            Assignee: Bill Havanki
>              Labels: newbie
>             Fix For: 1.6.0
>
>
> ConditionalMutation should define equals() and hashcode() methods that consider the conditions.
  Its parent class defines those methods, so it should.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message