accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1593) Looking up instanceName in ZK doesn't use consistent encoding
Date Sun, 01 Sep 2013 17:24:52 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755760#comment-13755760
] 

Mike Drob commented on ACCUMULO-1593:
-------------------------------------

{noformat}
+        instanceId = new String(iidb, "UTF-8");
{noformat}
I'd prefer a UTF-8 constant (preferably a {{CharSet}}, but I wouldn't complain about a {{String}}).

{noformat}
+        Log.warn("UTF-8 not supported");
{noformat}
Should use the existing {{log}} field instead of a static call to {{jline.internal.Log}}.
Actually, I'm not sure a warning is sufficient, since UTF-8 is one of the mandatory ones -
see http://docs.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html under Standard
Charsets.


Orthogonal comment - why do we store the bytes of a string of a UUID (40 bytes) instead of
the bytes of the longs of a UUID (16 bytes)?
                
> Looking up instanceName in ZK doesn't use consistent encoding
> -------------------------------------------------------------
>
>                 Key: ACCUMULO-1593
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1593
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Christopher Tubbs
>            Assignee: Ted Yu
>              Labels: newbie
>             Fix For: 1.6.0
>
>         Attachments: accumulo-1593-v1.txt
>
>
> We need to be more careful about encoding and decoding instance names and IDs in zookeeper.
They should use UTF-8 explicitly, right now, they use the JVM default, which can differ between
JVM runs (even between Initialize and start-all).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message