accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1158) Remove whitespace at end of lines in java files (a checkstyle rule)
Date Fri, 06 Sep 2013 16:31:52 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13760332#comment-13760332
] 

Christopher Tubbs commented on ACCUMULO-1158:
---------------------------------------------

I don't disagree with making the change throughout the code (and enforcing it in checkstyle
maven plugin). However, I was playing it safe.

Personally, I have Eclipse set to auto-format every file that I edit (in its entirety, not
just the parts I edit) and also add quality improvements, like missing @Override and @Deprecated
annotations and organizing imports, etc. I also tend to fix malformed javadocs or delete useless
javadocs (such as those with auto-generated @param tags but no comments). That way, at least
code I touch moves towards this, without being any more disruptive than the actual changes
I've made.
                
> Remove whitespace at end of lines in java files (a checkstyle rule)
> -------------------------------------------------------------------
>
>                 Key: ACCUMULO-1158
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1158
>             Project: Accumulo
>          Issue Type: Task
>            Reporter: David Medinets
>            Assignee: David Medinets
>            Priority: Trivial
>
> Maven has a checkstyle:checkstyle goal which, oddly enough, runs the checkstyle (http://checkstyle.sourceforge.net/)
tool that checks coding style. There are many rules available. When all rules are turned on,
there are over 80,000 messages. Changing the code base, all at once, to mitigate that many
messages is not feasible.
> In order to get the process moving, I suggest only the 'no whitespace at end of lines'
be turned on.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message