accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-527) Shell should have way to specify instance name while using ZK hosts from configuration
Date Thu, 19 Sep 2013 20:33:59 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13772272#comment-13772272
] 

Bill Havanki commented on ACCUMULO-527:
---------------------------------------

[~kturner] Your test updates are definitely an improvement, they look good to me. Thanks.

I needed to use PowerMock to mock the static method calls and object creations that are involved
in this area of the code - normally I'd use just EasyMock (and this is my first use of PowerMock
too!). And yes, the test ends up coupled to the implementation under test since the mocks
have to provide what the implementation is looking for. I'm not sure that another mock framework
could address that.

EasyMock and PowerMock were already under dependency management in the main POM before, so
I figured using them would be safe(st).
                
> Shell should have way to specify instance name while using ZK hosts from configuration
> --------------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-527
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-527
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 1.4.1
>            Reporter: John Vines
>            Assignee: Bill Havanki
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 1.6.0
>
>         Attachments: 0001-ACCUMULO-527-Add-zi-and-zh-options-for-shell.patch, 0002-ACCUMULO-527-Fix-indentation-in-Shell-from-last-comm.patch
>
>
> Currently the shell uses HDFSZooInstance unless otherwise specified. It is possible for
a user to force a ZooInstance, in which case they specify a list of ZKHosts and the instance
name. However, there is no way to specify an instance name and utilize the list of ZK hosts
in the configuration file. We should look into expanding the shell to include this creation
option, possibly by segregating the zookeeper hosts and instance name into two seperate arguments.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message