accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1605) stack overflow MilliSpan.java:113
Date Mon, 05 Aug 2013 12:21:55 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13729455#comment-13729455
] 

ASF subversion and git services commented on ACCUMULO-1605:
-----------------------------------------------------------

Commit ff226a78995057518ac354e671d90f1bb4c30884 in branch refs/heads/master from [~ecn]
[ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=ff226a7 ]

ACCUMULO-1605

Added many finally clauses to close spans in the presence of exceptions.

I suspect that the extreme depth of the traces is caused by traces that
are started and never stopped.  This most likely happens in the presence
of errors, where exceptions jump around the the span.stop calls.
In particular, when a file is missing for a compaction.  This is known
to occur in 1.4 when bulk imports fail.  See ACCUMULO-1044.

                
> stack overflow MilliSpan.java:113
> ---------------------------------
>
>                 Key: ACCUMULO-1605
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1605
>             Project: Accumulo
>          Issue Type: Bug
>          Components: trace
>    Affects Versions: 1.4.0, 1.4.1, 1.4.2, 1.4.3, 1.5.0
>            Reporter: Eric Newton
>             Fix For: 1.4.4, 1.5.1, 1.6.0
>
>
> In some strange cases, the recursive call to find a span's trace id blows the stack,
on MilliSpan.java, line 113.  [~kturner] and [~ecn] have reviewed the code, and nothing is
obvious.  Replace the recursive implementation with something more conservative.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message