accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1516) Clean up Constants
Date Thu, 18 Jul 2013 22:22:49 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712982#comment-13712982
] 

Christopher Tubbs commented on ACCUMULO-1516:
---------------------------------------------

[~vines] - With the metadata table being split into two tables, I'm not sure how it would
be sensible to keep that constant around. The code is still open for improvement, and I've
been thinking about additional improvements under the parent ticket of this one (ACCUMULO-1481).
For example, I've been working towards a cleaner API for metadata table operations (still
designed for internal use). Do you have a comment on the MetadataServicer I added? I do plan
on moving more code into that, and am open to feedback.

However, I don't see how we can sensibly preserve the METADATA_TABLE_NAME constant, as any
reasonable way somebody might have been trying to use this (despite it not being in the public
API), will likely be broken by ACCUMULO-1481.

I did try to preserve the Constants.NO_AUTHS as deprecated (and replaced it with Authorizations.EMPTY),
because I thought that is something users would likely use. I'm also willing to deprecate
other constants, as needed, but I don't see merit in preserving them all, since they were
never part of the public API, and most aren't even useful outside of internal code.
                
> Clean up Constants
> ------------------
>
>                 Key: ACCUMULO-1516
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1516
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: client, master, tserver
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>             Fix For: 1.6.0
>
>
> o.a.a.core.Constants has become a mess, full of both useful and not useful stuff that
is difficult to sift through.
> For instance, there's a String literal constant for "UTF-8" that is only ever used in
one place, and Constants.NO_AUTHS should really be Authorizations.EMPTY
> Some of this, I want/need to clean up so I can track down all the important bits to migrate
the root tablet to its own table without clutter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message