accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1309) IntersectingIterator.addSource has unecessary object creation
Date Mon, 22 Jul 2013 17:08:50 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13715375#comment-13715375
] 

Christopher Tubbs commented on ACCUMULO-1309:
---------------------------------------------

I lean slightly in favor of removing unused code, but a trivial use case could change my mind.
I do think we should decide for 1.6.0, so we can deprecate sooner rather than later, or so
we can mark it "newbie" to implement.
                
> IntersectingIterator.addSource has unecessary object creation
> -------------------------------------------------------------
>
>                 Key: ACCUMULO-1309
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1309
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>            Reporter: John Vines
>            Assignee: Billie Rinaldi
>
> Taken from TODOs-
> II uses a static array for holding sources and resizes +1 each time it fills. It would
be better off as a List or something along those lines to prevent a lot of unnecessary object
creation.
> Additionally, every time is does migrate to a new static array, it creates a new copy
of the contained objects.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message