accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (ACCUMULO-1006) Add test for VisibilityParseException
Date Tue, 09 Jul 2013 22:23:49 GMT

     [ https://issues.apache.org/jira/browse/ACCUMULO-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mike Drob updated ACCUMULO-1006:
--------------------------------

    Fix Version/s:     (was: 1.4.4)
       Issue Type: Improvement  (was: Bug)

Ok, to recap - there are some unclear design decisions made regarding the exception throwing
in checking visibilities against authorizations. Specifically, there is a checked VisibilityParseException
that is never thrown and an unchecked BadArgumentException which is too generic to be meaningful.
The parsing code should be straightened out, and more heavily unit tested.

I'm removing the 1.4.4 fix version and marking this as an improvement to revisit for 1.5.1
and 1.6.0.
                
> Add test for VisibilityParseException
> -------------------------------------
>
>                 Key: ACCUMULO-1006
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1006
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: tserver
>    Affects Versions: 1.4.2, 1.5.0
>            Reporter: Christopher Tubbs
>            Assignee: Keith Turner
>             Fix For: 1.5.1, 1.6.0
>
>
> I'm not sure this exception can ever actually happen. I think ColumnVisibility throws
BadArgumentException in all the cases where the VisibilityParseException would have been thrown.
It's somewhat unfortunate that the BadArgumentException is the RuntimeException, and the checked
exception can never happen.
> We need a test to see if we can make VisibilityParseException happen when BadArgumentException
doesn't, and possibly do something about BadArgumentException, by either wrapping it with
a checked exception, or something else to reflect the fact that it's more likely to happen
than VisibilityParseException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message