Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 67DEDC736 for ; Wed, 19 Jun 2013 23:02:20 +0000 (UTC) Received: (qmail 15683 invoked by uid 500); 19 Jun 2013 23:02:20 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 15658 invoked by uid 500); 19 Jun 2013 23:02:20 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 15649 invoked by uid 99); 19 Jun 2013 23:02:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Jun 2013 23:02:20 +0000 Date: Wed, 19 Jun 2013 23:02:19 +0000 (UTC) From: "Josh Elser (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-1504) IteratorSetting missing equals and hashCode methods MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688599#comment-13688599 ] Josh Elser commented on ACCUMULO-1504: -------------------------------------- r1494797 Committed patch to trunk, with a few modifications to the IteratorSettingTest class you provided. Thanks for the patch! Devs, given we're in the middle of a talk about backports and things, what's the consensus here? I'm for pulling this back to 1.4 and 1.5. > IteratorSetting missing equals and hashCode methods > --------------------------------------------------- > > Key: ACCUMULO-1504 > URL: https://issues.apache.org/jira/browse/ACCUMULO-1504 > Project: Accumulo > Issue Type: Improvement > Components: client > Affects Versions: 1.4.3 > Reporter: Josh Elser > Assignee: Miguel Pereira > Fix For: 1.4.4, 1.5.1, 1.6.0 > > Attachments: ACCUMULO-1504.patch > > > When writing tests to assert expected configuration of IteratorSettings, it would sure be nice if you could actually call IteratorSetting.equals(IteratorSetting) instead of forcing the client to manually implement this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira