Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5A0BF104C1 for ; Wed, 19 Jun 2013 03:53:27 +0000 (UTC) Received: (qmail 2473 invoked by uid 500); 19 Jun 2013 03:53:23 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 2445 invoked by uid 500); 19 Jun 2013 03:53:22 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 2428 invoked by uid 99); 19 Jun 2013 03:53:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Jun 2013 03:53:20 +0000 Date: Wed, 19 Jun 2013 03:53:19 +0000 (UTC) From: "Corey J. Nolet (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-1499) Move sanity checks from MiniAccumuloCluster constructor into MiniAccumuloConfig.initialize method. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687566#comment-13687566 ] Corey J. Nolet commented on ACCUMULO-1499: ------------------------------------------ Patch applied, thanks! > Move sanity checks from MiniAccumuloCluster constructor into MiniAccumuloConfig.initialize method. > -------------------------------------------------------------------------------------------------- > > Key: ACCUMULO-1499 > URL: https://issues.apache.org/jira/browse/ACCUMULO-1499 > Project: Accumulo > Issue Type: Improvement > Affects Versions: 1.6.0 > Reporter: David Medinets > Priority: Trivial > Fix For: 1.6.0 > > Attachments: ACCUMULO-1499.patch > > > The code below seems like it should be in the config class: > if (config.getDir().exists() && !config.getDir().isDirectory()) > throw new IllegalArgumentException("Must pass in directory, " + config.getDir() + " is a file"); > if (config.getDir().exists() && config.getDir().list().length != 0) > throw new IllegalArgumentException("Directory " + config.getDir() + " is not empty"); > this.config = config.initialize(); > Any objections to this change? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira