accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miguel Pereira (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1499) Move sanity checks from MiniAccumuloCluster constructor into MiniAccumuloConfig.initialize method.
Date Fri, 14 Jun 2013 18:36:19 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683643#comment-13683643
] 

Miguel Pereira commented on ACCUMULO-1499:
------------------------------------------

Ops, your right Corey I was on 1.5 branch. Although The code change is almost identical. Ill
put up a new patch if needed?
                
> Move sanity checks from MiniAccumuloCluster constructor into MiniAccumuloConfig.initialize
method.
> --------------------------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-1499
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1499
>             Project: Accumulo
>          Issue Type: Improvement
>    Affects Versions: 1.6.0
>            Reporter: David Medinets
>            Priority: Trivial
>             Fix For: 1.6.0
>
>         Attachments: ACCUMULO-1499.patch
>
>
> The code below seems like it should be in the config class:
>     if (config.getDir().exists() && !config.getDir().isDirectory())
>       throw new IllegalArgumentException("Must pass in directory, " + config.getDir()
+ " is a file");
>     if (config.getDir().exists() && config.getDir().list().length != 0)
>       throw new IllegalArgumentException("Directory " + config.getDir() + " is not empty");
>     this.config = config.initialize();
> Any objections to this change?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message