Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D45EE9143 for ; Thu, 16 May 2013 19:05:36 +0000 (UTC) Received: (qmail 45674 invoked by uid 500); 16 May 2013 19:05:36 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 45646 invoked by uid 500); 16 May 2013 19:05:36 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 45637 invoked by uid 99); 16 May 2013 19:05:36 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 May 2013 19:05:36 +0000 Date: Thu, 16 May 2013 19:05:35 +0000 (UTC) From: "Billie Rinaldi (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-1394) Allow RegExFilter subclass to call setNegate. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13659834#comment-13659834 ] Billie Rinaldi commented on ACCUMULO-1394: ------------------------------------------ There is no direct link in the new JIRA. Once Jenkins builds the changes, it will post a comment with the result and some links. (The new system is definitely not as good as the old one.) > Allow RegExFilter subclass to call setNegate. > --------------------------------------------- > > Key: ACCUMULO-1394 > URL: https://issues.apache.org/jira/browse/ACCUMULO-1394 > Project: Accumulo > Issue Type: Improvement > Affects Versions: 1.5.0, 1.4.1, 1.4.2, 1.6.0, 1.4.3, 1.4.4 > Reporter: David Medinets > Assignee: Christopher Tubbs > Priority: Minor > Fix For: 1.5.0, 1.4.4 > > > I wrote an iterator that sets RegExFilter options inside its init() method. I created a HashMap to hold options, then added entries for RegExFilter.COLF_REGEX. However, the Filter.NEGATE is private and the setNegate function only accepts an IteratorSetting option which I don't have inside my iterator's init() method (true?). So I simply used a "negate" string literal which I don't like. > I propose making NEGATE public as is done in the RegExFilter class. Any reason not to? Is there a better approach? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira