Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Wed, 8 May 2013 19:53:16 +0000 (UTC)
From: "Billie Rinaldi (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12646665.1368037271890.289564.1368042796574@arcas>
In-Reply-To: <JIRA.12646665.1368037271890@arcas>
References: <JIRA.12646665.1368037271890@arcas>
Subject: [jira] [Commented] (ACCUMULO-1394) Allow RegExFilter subclass to
 call setNegate.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652264#comment-13652264 ] 

Billie Rinaldi commented on ACCUMULO-1394:
------------------------------------------

I think it should work.  Making it protected seems fine to me, if that does work for you.
                
> Allow RegExFilter subclass to call setNegate.
> ---------------------------------------------
>
>                 Key: ACCUMULO-1394
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1394
>             Project: Accumulo
>          Issue Type: Improvement
>    Affects Versions: 1.5.0, 1.4.1, 1.4.2, 1.6.0, 1.4.3, 1.4.4
>            Reporter: David Medinets
>            Priority: Minor
>             Fix For: 1.5.0, 1.4.4
>
>
> I wrote an iterator that sets RegExFilter options inside its init() method. I created a HashMap to hold options, then added entries for RegExFilter.COLF_REGEX. However, the Filter.NEGATE is private and the setNegate function only accepts an IteratorSetting option which I don't have inside my iterator's init() method (true?). So I simply used a "negate" string literal which I don't like.
> I propose making NEGATE public as is done in the RegExFilter class. Any reason not to? Is there a better approach?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira