accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Billie Rinaldi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1394) Allow RegExFilter subclass to call setNegate.
Date Wed, 08 May 2013 18:59:16 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652227#comment-13652227
] 

Billie Rinaldi commented on ACCUMULO-1394:
------------------------------------------

I think we were trying to avoid making option names such as NEGATE available to users.  (RegExFilter
options were grandfathered in.)  I take it your iterator doesn't extend Filter, so protected
wouldn't be sufficient?
                
> Allow RegExFilter subclass to call setNegate.
> ---------------------------------------------
>
>                 Key: ACCUMULO-1394
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1394
>             Project: Accumulo
>          Issue Type: Improvement
>    Affects Versions: 1.5.0, 1.4.1, 1.4.2, 1.6.0, 1.4.3, 1.4.4
>            Reporter: David Medinets
>            Priority: Minor
>             Fix For: 1.5.0, 1.4.4
>
>
> I wrote an iterator that sets RegExFilter options inside its init() method. I created
a HashMap to hold options, then added entries for RegExFilter.COLF_REGEX. However, the Filter.NEGATE
is private and the setNegate function only accepts an IteratorSetting option which I don't
have inside my iterator's init() method (true?). So I simply used a "negate" string literal
which I don't like.
> I propose making NEGATE public as is done in the RegExFilter class. Any reason not to?
Is there a better approach?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message