accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Corey J. Nolet (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1357) Make debugging MiniAccumuloCluster easier
Date Thu, 09 May 2013 16:55:16 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653067#comment-13653067
] 

Corey J. Nolet commented on ACCUMULO-1357:
------------------------------------------

Hey Keith,

I noticed your commit and merged it with my ACCUMULO-1386 branch already. I
don't mind using bytes only for the JVM Xmx in the MiniAccumuloCluster,
though it does make the processes a little more complicated for a user to
read when they do a "ps" command. I added the suffix back in to make it
easier to parse from a memory string in a property file- so a user can
input "128M" and we can match "M" up with the correct MemoryUnit. We should
be able to make future changes to the MemoryUnit and know that all other
code will continue to work. Also, I found myself wanting to write this
method to validate any memory inputs from the property file:

{code:java}
  private static boolean validateMemoryString(String memoryString) {
    String unitsRegex = "[";
    MemoryUnit[] units = MemoryUnit.values();
    for(int i = 0; i < units.length; i++) {
      unitsRegex += units[i].suffix();
      if(i < units.length - 1)
        unitsRegex += "|";
    }
    unitsRegex += "]";
    Pattern p = Pattern.compile("\\d+" + unitsRegex);
    return p.matcher(memoryString).matches();
  }
{code}




                
> Make debugging MiniAccumuloCluster easier
> -----------------------------------------
>
>                 Key: ACCUMULO-1357
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1357
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Keith Turner
>            Assignee: Corey J. Nolet
>             Fix For: 1.6.0
>
>         Attachments: ACCUMULO-1357.1.patch, ACCUMULO-1357.2.patch
>
>
> When a problem occurs with MiniAccumuloCluster it can be difficult to debug.  Something
that may make this easier.
>  * The ability to easily access log files. (maybe have a method users could call to copy
log files to a target dir).
>  * Starting Accumulo server processes with remote JVM debugging enabled.  (this could
be a statup option, could have method users could call to get the debug ports)
> It would be nice if a unit test fails in a maven run if the MiniAcc logs files would
end up the target dir that contains info about test failures.  Make it as easy as possible
to do this from junit test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message