Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Fri, 19 Apr 2013 15:31:28 +0000 (UTC)
From: "Billie Rinaldi (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12643080.1366240752374.193395.1366385488003@arcas>
In-Reply-To: <JIRA.12643080.1366240752374@arcas>
References: <JIRA.12643080.1366240752374@arcas>
Subject: [jira] [Commented] (ACCUMULO-1309) IntersectingIterator.addSource
 has unecessary object creation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636487#comment-13636487 ] 

Billie Rinaldi commented on ACCUMULO-1309:
------------------------------------------

The addSource method appears never to be used; sources are created in their entirety in the init method.  Perhaps we could deprecate and remove addSource?
                
> IntersectingIterator.addSource has unecessary object creation
> -------------------------------------------------------------
>
>                 Key: ACCUMULO-1309
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1309
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>            Reporter: John Vines
>            Assignee: Billie Rinaldi
>
> Taken from TODOs-
> II uses a static array for holding sources and resizes +1 each time it fills. It would be better off as a List or something along those lines to prevent a lot of unnecessary object creation.
> Additionally, every time is does migrate to a new static array, it creates a new copy of the contained objects.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira