Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B9FC7F25B for ; Mon, 8 Apr 2013 18:53:19 +0000 (UTC) Received: (qmail 19628 invoked by uid 500); 8 Apr 2013 18:53:18 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 19595 invoked by uid 500); 8 Apr 2013 18:53:18 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 19526 invoked by uid 99); 8 Apr 2013 18:53:18 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Apr 2013 18:53:18 +0000 Date: Mon, 8 Apr 2013 18:53:18 +0000 (UTC) From: "Hudson (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-1252) Race condition in BulkImport causes ConcurrentModificationException MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625661#comment-13625661 ] Hudson commented on ACCUMULO-1252: ---------------------------------- Integrated in Accumulo-Trunk-Hadoop-2.0 #181 (See [https://builds.apache.org/job/Accumulo-Trunk-Hadoop-2.0/181/]) ACCUMULO-1252 remove loaded files outside the threadpool (Revision 1465690) Result = SUCCESS ecn : Files : * /accumulo/trunk * /accumulo/trunk/assemble * /accumulo/trunk/core * /accumulo/trunk/examples * /accumulo/trunk/fate/src/main/java/org/apache/accumulo/fate/ZooStore.java * /accumulo/trunk/fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooSession.java * /accumulo/trunk/server * /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/master/tableOps/BulkImport.java * /accumulo/trunk/src > Race condition in BulkImport causes ConcurrentModificationException > ------------------------------------------------------------------- > > Key: ACCUMULO-1252 > URL: https://issues.apache.org/jira/browse/ACCUMULO-1252 > Project: Accumulo > Issue Type: Bug > Affects Versions: 1.4.2 > Reporter: William Slacum > > The LoadFiles class gets a synchronized list of files to import and, while iterating over that list, creates another list of Callable's. If the list of files to load is long enough, it's possible that a bulk import on a previous file in the list could finish and remove itself from the master list before all of the commands to import the rest of the files are created. This causes a ConcurrentModificationException when trying to fetch the next file to load. > I think the concurrent lists support an iterator that will not fail if the underlying list is modified, but if not, I think this can be solved by first creating a list of Callables and then adding them to the thread pool in a separate loop. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira