Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ADAAFFE4E for ; Tue, 16 Apr 2013 21:53:21 +0000 (UTC) Received: (qmail 82365 invoked by uid 500); 16 Apr 2013 21:53:17 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 82322 invoked by uid 500); 16 Apr 2013 21:53:17 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 82219 invoked by uid 99); 16 Apr 2013 21:53:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Apr 2013 21:53:17 +0000 Date: Tue, 16 Apr 2013 21:53:17 +0000 (UTC) From: "John Vines (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-1026) Don't use @Deprecated to mean "Not for Client Use" MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633432#comment-13633432 ] John Vines commented on ACCUMULO-1026: -------------------------------------- I'm starting to wonder if this should be kicked to 1.6 since you're planning on more jar reconfiguration, which I believe involves a bit of maven-fu. > Don't use @Deprecated to mean "Not for Client Use" > -------------------------------------------------- > > Key: ACCUMULO-1026 > URL: https://issues.apache.org/jira/browse/ACCUMULO-1026 > Project: Accumulo > Issue Type: Sub-task > Components: master, tserver > Reporter: Christopher Tubbs > Assignee: Christopher Tubbs > Fix For: 1.5.0 > > > I understand the convenience of using "@Deprecated" to discourage users from using some bit of code, but I think this is confusing to users, because it doesn't actually mean the functionality is deprecated. This sets a bad precedent, because users may start getting the impression that when we say something is deprecated, we don't really mean it, that we're just keeping something from them. > Further, using this tag liberally for other purposes, requires us to pollute the code with suppression of warnings, which may hide other potential issues. This wouldn't be an issue if the code were actually deprecated, because we should no longer be using the code ourselves. > These extra tags got checked in for ACCUMULO-259, and I think they should be cleaned up. > Some options are: > # Create another annotation for annotating the public API > # Create an annotation for annotating "Not For Client Use" when it is inconvenient to remove a method from the API. > # Use an interface so the method isn't exposed in our public API -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira