accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1289) Re-establish SimpleTest for Proxy against MiniAccumuloCluster
Date Thu, 18 Apr 2013 18:22:14 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635474#comment-13635474
] 

Keith Turner commented on ACCUMULO-1289:
----------------------------------------

Some comments on ACCUMULO-1289.patch

There are way more than diffs that would have I expected between ProxyServer in 1.4 and 1.5.
 This is may not be an issue with this patch, but I noticed it while looking at this patch.
  If this not resolved, I would be reluctant to release the proxy in 1.4.  I do not think
we should release it for 1.4 and not support it.  In its current state, patching bug fixes
to 1.4 and 1.5 would be painful and error prone.   Can anyone provide insight into this issue?

ProxyServer is missing apache header.  I suppose this was an issue with the previous patch.

I had to reformat SimpleTest in 1.4 and 1.5 to get it to compare nicely.   After doing this
I noticed the following :

  * Why not use getRandomProtocol() in 1.4 test?  I have actually found proxy bugs in 1.5
by changing the protocol.  
  * One test uses a constant of 10 and the other 100.  Why the diff.
  * While comparing SimpleTest in the patch, I noticed some bugs in 1.5 that I think your
patch fixes?  I just checked in a fix for those to 1.5.  r1469503

The patch changed thrift IDL, but does not include regenerated thrift code.  I generated it
using thrift 0.6.1 to experiment with the patch.


                
> Re-establish SimpleTest for Proxy against MiniAccumuloCluster
> -------------------------------------------------------------
>
>                 Key: ACCUMULO-1289
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1289
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: proxy
>            Reporter: Corey J. Nolet
>            Assignee: Corey J. Nolet
>            Priority: Minor
>             Fix For: 1.4.4
>
>         Attachments: ACCUMULO-1289.patch
>
>
> Currently the SimpleTest for the proxy server backported from 1.5 is using MockAccumulo
behind it- which isn't making me confident about the proxy and how it may change over time
with future bug fixes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message