accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1237) Back port the MiniAccumuloCluster from 1.5 to 1.4.*
Date Wed, 17 Apr 2013 13:37:17 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634025#comment-13634025
] 

Keith Turner commented on ACCUMULO-1237:
----------------------------------------

[~sonixbp] a few comments on patch #3. I noticed the unit test was using slf4j.  I think most
of the Accumulo code uses log4j.  For consistency, I think it would be better to stick w/
one logging package. I like the message you are logging about the dir its running in, that
could be really useful for debugging.  

Also the formatting is still kinda off.  I notice this because I am diffing the 1.4 and 1.5
code. There are a lot of white space diffs that add a lot of noise.  When I reformat the patch
#3, I get few diffs between 1.4 and 1.5.  This is nice for merging bug fixes between branches.
  How are you formatting the code?  I am curious what the difference is.

The patch looks good otherwise.
                
> Back port the MiniAccumuloCluster from 1.5 to 1.4.*
> ---------------------------------------------------
>
>                 Key: ACCUMULO-1237
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1237
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: test
>            Reporter: Corey J. Nolet
>            Assignee: Corey J. Nolet
>            Priority: Minor
>             Fix For: 1.4.4
>
>         Attachments: ACCUMULO-1237-3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message