accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1005) Authorizations and ColumnVisibility API should not accept Charset param
Date Mon, 08 Apr 2013 14:49:15 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625425#comment-13625425
] 

Keith Turner commented on ACCUMULO-1005:
----------------------------------------

I do not think the initial assumption of this ticket is valid.  The String functions are provided
for convenience.    Internally Accumulo treats this data as byte arrays.  Accumulo does not
care about encoding, if the user wants to use something besides utf8 then that will not break
anything internally.   For example, the following constructors take byte arrays.

{code:java}
   public Authorizations(Collection<byte[]> authorizations)
{code}

{code:java}
   public ColumnVisibility(byte[] expression)
{code}

More specifically, the language is defined by bytes that correspond to certain characters
in ASCII.  Between quotes you can have any bytes you like, it does not matter what they are,
all comparisons are done using byte arrays.  
                
> Authorizations and ColumnVisibility API should not accept Charset param
> -----------------------------------------------------------------------
>
>                 Key: ACCUMULO-1005
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1005
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Christopher Tubbs
>            Assignee: Tim Reardon
>             Fix For: 1.5.0
>
>         Attachments: ACCUMULO-1005.patch
>
>
> The Charset parameter was added to the public API for ACCUMULO-241. However, this intermingles
internal serialization/comparison implementation, and the semantics of the public API.
> The Charset parameter effectively instructs Accumulo how to serialize the object. This
can break the comparison with what is stored in the table and is an unnecessary breakage.
> In the public API, we should only accept Strings, and allow any valid java String. Internally,
the serialization of these should consistently be UTF-8.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message