Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EFD3DDEA9 for ; Mon, 4 Mar 2013 18:17:14 +0000 (UTC) Received: (qmail 59967 invoked by uid 500); 4 Mar 2013 18:17:14 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 59934 invoked by uid 500); 4 Mar 2013 18:17:14 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 59925 invoked by uid 99); 4 Mar 2013 18:17:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Mar 2013 18:17:14 +0000 Date: Mon, 4 Mar 2013 18:17:14 +0000 (UTC) From: "Hudson (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-1002) Lift close method on TabletServerBatchReaderImpl to ScannerBase MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592439#comment-13592439 ] Hudson commented on ACCUMULO-1002: ---------------------------------- Integrated in Accumulo-Trunk-Hadoop-2.0 #115 (See [https://builds.apache.org/job/Accumulo-Trunk-Hadoop-2.0/115/]) merged changes from 1.5 ACCUMULO-1142 Enable redirectTestOutputToFile in surefire plugin to nuke test output ACCUMULO-1002 Apply override annotation to the close method on the BatchScanner implementation to be explicit ACCUMULO-1002 Add a close method to ScannerBase and a no-op impl to ScannerOptions. ACCUMULO-1104 Another update to account for 1.5 changes in the user manual ACCUMULO-1071 Changing wording from "hadoop library type" to "Accumulo memory-map type" ACCUMULO-1104 ACCUMULO-1136 Applying additional wording for using config as opposed to setiter. Fix various other documentation which are now incorrect in 1.5. ACCUMULO-1104 Correcting documented option to show timestamps in shell in user manual. (Revision 1452342) Result = SUCCESS kturner : Files : * /accumulo/trunk * /accumulo/trunk/assemble * /accumulo/trunk/bin/bootstrap_config.sh * /accumulo/trunk/core * /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/ScannerBase.java * /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/ScannerOptions.java * /accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReader.java * /accumulo/trunk/docs/src/user_manual/accumulo_user_manual.tex * /accumulo/trunk/docs/src/user_manual/chapters/administration.tex * /accumulo/trunk/docs/src/user_manual/chapters/clients.tex * /accumulo/trunk/docs/src/user_manual/chapters/shell.tex * /accumulo/trunk/docs/src/user_manual/chapters/table_configuration.tex * /accumulo/trunk/examples * /accumulo/trunk/fate/src/main/java/org/apache/accumulo/fate/ZooStore.java * /accumulo/trunk/fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooSession.java * /accumulo/trunk/pom.xml * /accumulo/trunk/server * /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/monitor/servlets/trace/NullScanner.java * /accumulo/trunk/src > Lift close method on TabletServerBatchReaderImpl to ScannerBase > --------------------------------------------------------------- > > Key: ACCUMULO-1002 > URL: https://issues.apache.org/jira/browse/ACCUMULO-1002 > Project: Accumulo > Issue Type: Improvement > Components: client > Affects Versions: 1.4.2 > Reporter: Josh Elser > Assignee: Josh Elser > Fix For: 1.5.0 > > > There's a long standing known silly "issue" where the Scanner interface doesn't have a close method, while the BatchScanner does. > Both inherit from a common ScannerBase, so it seems awkward that the interface is the same for both Scanner and BatchScanner (even if the close method on Scanner is a noop) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira