accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1002) Lift close method on TabletServerBatchReaderImpl to ScannerBase
Date Mon, 04 Mar 2013 03:11:13 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591955#comment-13591955
] 

Hudson commented on ACCUMULO-1002:
----------------------------------

Integrated in Accumulo-1.5 #12 (See [https://builds.apache.org/job/Accumulo-1.5/12/])
    ACCUMULO-1002 Apply override annotation to the close method on the BatchScanner implementation
to be explicit (Revision 1452169)
ACCUMULO-1002 Add a close method to ScannerBase and a no-op impl to ScannerOptions. (Revision
1452168)

     Result = FAILURE
elserj : 
Files : 
* /accumulo/branches/1.5/core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReader.java

elserj : 
Files : 
* /accumulo/branches/1.5/core/src/main/java/org/apache/accumulo/core/client/ScannerBase.java
* /accumulo/branches/1.5/core/src/main/java/org/apache/accumulo/core/client/impl/ScannerOptions.java
* /accumulo/branches/1.5/server/src/main/java/org/apache/accumulo/server/monitor/servlets/trace/NullScanner.java

                
> Lift close method on TabletServerBatchReaderImpl to ScannerBase
> ---------------------------------------------------------------
>
>                 Key: ACCUMULO-1002
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1002
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 1.4.2
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 1.5.0
>
>
> There's a long standing known silly "issue" where the Scanner interface doesn't have
a close method, while the BatchScanner does.
> Both inherit from a common ScannerBase, so it seems awkward that the interface is the
same for both Scanner and BatchScanner (even if the close method on Scanner is a noop)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message