accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-650) Add table descriptions
Date Mon, 25 Mar 2013 15:49:16 GMT


Keith Turner commented on ACCUMULO-650:

I reviewed the patch and compiled some comments.  Then I thought of a totally different way
to go about this.  I decided to include the comments as they may be informative.

 * this brings the # of create table methods to 6.  I am thinking it would be good to introduce
a config object (maybe class NewTableConfig) thats passed to create table.  Like BatchWriterConfig
that was introduced in 1.5. This way as we add options to create table in the future, we do
not need to add new create methods.
 * I do not think the FATE operation needs to get the tableNameLock, its getting the table
write lock on the table. The table name lock is special lock in the master for table names,
the table name is not being changed.
  * Do not need get the old table description and check that in the zookeeper mutate call.
 Do not even need to call mutate, just set the desciption.  Mutate is useful for applying
a function to existing data in zookeeper, that is not the case here.  For example, mutate
would be useful for adding one to something in zookeeper.  Use mutate for compare and set
  * should check that the user has alter_table permission for updateDesc
  * do we want to the user to have a permission (like read table, to get the desciption?)
  * If you deserialize an old TableInfo object (e.g. from FATE op create in 1.5), then tableDescription
may be null.  So would need to handle null.  Same for ImportedTableInfo.
  * Export table output some informational data in the export file.  I think it would be nice
to include the table desc.  I think it would be good to do this as a sub-task, after this
initial task is done.

While reviewing the shell code, I started thinking of an entirely different way to go about
doing this.  Use a new per table config.  For example, could do the following in the shell.

  config -t table_foo -s table.description=test

This would naturally be copied by export and clone.  Setting a config already requires alter

> Add table descriptions
> ----------------------
>                 Key: ACCUMULO-650
>                 URL:
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: master
>            Reporter: John Vines
>            Assignee: Kevin Faro
>         Attachments: ACCUMULO-650.patch
> We should add a table description field, probably in zookeeper, to store an optional
field end users can use to provide their relevant information on the table.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message