accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Faro (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (ACCUMULO-1051) Authorizations has inconsistent serialization
Date Thu, 14 Feb 2013 00:50:12 GMT

     [ https://issues.apache.org/jira/browse/ACCUMULO-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kevin Faro updated ACCUMULO-1051:
---------------------------------

    Status: Patch Available  (was: Open)

I left auths to be a HashSet, changed the checkAuths method to sort the authorizations before
storing them in the authsList (so it only sorts once) and then serialize() iterates over the
authsList instead of auths.

Also, this now passes the ShellTest.authsTest that was failing in Hudson.

What do you think?
                
> Authorizations has inconsistent serialization
> ---------------------------------------------
>
>                 Key: ACCUMULO-1051
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1051
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>            Reporter: Christopher Tubbs
>            Assignee: Kevin Faro
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 1.5.0
>
>         Attachments: accumulo-1051.patch
>
>
> The same set of authorizations may not serialize to the same value each time, if specified
in a different order when constructed (like new Authorizations("a", "b") and new Authorizations("b",
"a")), because serialization reproducibility depends on the insert order in the underlying
HashSet.
> So, one could get the following to happen:
> {code:java}
> true == auths1.equals(auths2) && !auths1.serialize().equals(auths2.serialize());
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message