accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-842) Fate operations should be rolled into shell
Date Wed, 20 Feb 2013 22:57:12 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13582626#comment-13582626
] 

Keith Turner commented on ACCUMULO-842:
---------------------------------------

I just experimented with #4, it works great.   I had not really looked at the code too closely
since #2.   I should have experimented and reviewed the code, instead of just experimenting.
 I noticed some code changes that would be nice.   Instead of getting the zookeeper host and
timeout from config, I think we should use the following two methods to get these 

{code:java}
    shellState.getConnector().getInstance().getZooKeepers()
    shellState.getConnector().getInstance().getZooKeepersSessionTimeOut()
{code}

If this is done, then I think the command will not depend on the config at all.   The client
code used to have a lot of dependencies on these config files, which are mainly intended for
servers.  We have been trying to remove these dependencies on the config files from client
code.

One other little thing, all of the shell commands do something like if(cl.hasOption(statusOption.getOpt())),where
the code has if(cl.hasOption('t')).


                
> Fate operations should be rolled into shell
> -------------------------------------------
>
>                 Key: ACCUMULO-842
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-842
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: shell
>            Reporter: John Vines
>            Assignee: Damon A. Brown
>            Priority: Minor
>             Fix For: 1.6.0
>
>         Attachments: FateCommand-2.patch, FateCommand-3.patch, FateCommand-4.patch, FateCommand.patch
>
>
> Fate is nifty but the only ways to deal with it are by directly calling some utility
jars. We should roll this functionality into the shell to make it easier to manage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message