accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-842) Fate operations should be rolled into shell
Date Tue, 12 Feb 2013 21:33:14 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577032#comment-13577032
] 

Keith Turner commented on ACCUMULO-842:
---------------------------------------

Damon,

Thanks for the patch, I have a few comments.

 * I am not keen on having an option to run if the master lock is held.  I think modifications
to Fate ops should only run if the master lock is not held. If there is a buggy fate op thats
stuck in an infinite loop, deleting it from the ZooStore will not necessarily kill the thread
in the master.  In the case a user would still need to kill the master.  I would not want
the user to get the impression that this shell command will clean up state in the master process,
it will not.   Also, could get strange behavior in the master from concurrent modification
of zookeeper.  I think always killing the master process is the safest option.  Killing the
master for a bit should not impact reads and writes to Accumulo, but it will stall table operations.
 * seems to duplicates some code in AdminUtil, consolidate?
 * TxFailCommand.prepFail() is a nice improvement, I think this could be moved to fate.AdminUtil
and have shell call AdminUtil
 * TxDeleteCommand.prepDelete() should always delete, even its NEW or IN_PROGRESS. Consider
a buggy fate op thats in progress and always gets stuck in an infinite loop when it tries
to run.   Maybe just use fate.AdminUtil.prepDelete().
 * consider using shellState.printLines(), it does pagination, in TxPrintCommand
 * javadoc for TxPrintCommand wrong
 * I think I am slightly in favor of having one shell command with options, less clutter in
the shells list of commands.  Was there a reason you chose to create three commands?
 * Did you use the Accumulo Eclipse formatter?  The formatting seems mostly correct, but I
am seeing some slight diffs like extra spaces in parametric types.  Its odd.
 * May want to consider making the current Admin command log a warning saying its deperecated
and point users to the shell commands.

For testing, you can pick a random fate op and add an infinite loop to it :)
                
> Fate operations should be rolled into shell
> -------------------------------------------
>
>                 Key: ACCUMULO-842
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-842
>             Project: Accumulo
>          Issue Type: Bug
>          Components: shell
>            Reporter: John Vines
>            Assignee: John Vines
>            Priority: Minor
>         Attachments: FateShellCommands.patch
>
>
> Fate is nifty but the only ways to deal with it are by directly calling some utility
jars. We should roll this functionality into the shell to make it easier to manage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message