Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Wed, 14 Nov 2012 18:36:13 +0000 (UTC)
From: "Eric Newton (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <353541009.114944.1352918173698.JavaMail.jiratomcat@arcas>
In-Reply-To: <1563689631.114879.1352917452654.JavaMail.jiratomcat@arcas>
Subject: [jira] [Resolved] (ACCUMULO-855) Patch to remove acquisition of
 redundant lock: LiveTServerSet in org.apache.accumulo.server.master
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/ACCUMULO-855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Newton resolved ACCUMULO-855.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5.0

patch applied with r1409288.  Nice catch.
                
> Patch to remove acquisition of redundant lock: LiveTServerSet in org.apache.accumulo.server.master
> --------------------------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-855
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-855
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Tim Halloran
>            Priority: Minor
>             Fix For: 1.5.0
>
>         Attachments: LiveTServerSet.java.patch
>
>
> A lock on the receiver is acquired twice by this method. This has two drawbacks (a) it slows performance and (b) is confusing.
> A patch is attached proposing the fix -- I left the method synchronized and removed the lock acquisition in the method to match the other methods in the class.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira