Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Fri, 16 Nov 2012 14:50:13 +0000 (UTC)
From: "Eric Newton (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <1994016537.123960.1353077413942.JavaMail.jiratomcat@arcas>
In-Reply-To: <429979286.85441.1352351652433.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (ACCUMULO-845) Handle method.include calls
 consistently in TraceWrap class.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498839#comment-13498839 ] 

Eric Newton commented on ACCUMULO-845:
--------------------------------------

I'm going to fix this in trunk.  Do you think this should be back-ported to 1.4?
                
> Handle method.include calls consistently in TraceWrap class.
> ------------------------------------------------------------
>
>                 Key: ACCUMULO-845
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-845
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: David Medinets
>            Priority: Minor
>
> One call ignores exceptions and one call handles exceptions.
> {noformat}
>  if (args == null || args.length < 1 || args[0] == null || !(args[0] instanceof TInfo)) {
>   return method.invoke(instance, args);
>  }       
>  Span span = Trace.trace((TInfo) args[0], method.getName());
>  try {   
>     return method.invoke(instance, args);
>  } catch (InvocationTargetException ex) {
>    throw ex.getCause();
>  } finally {
>    span.stop();
>  }       
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira