accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Medinets (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (ACCUMULO-845) Handle method.include calls consistently in TraceWrap class.
Date Thu, 08 Nov 2012 12:31:12 GMT

     [ https://issues.apache.org/jira/browse/ACCUMULO-845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

David Medinets updated ACCUMULO-845:
------------------------------------

    Description: 
One call ignores exceptions and one call handles exceptions.
{noformat}
 if (args == null || args.length < 1 || args[0] == null || !(args[0] instanceof TInfo))
{
  return method.invoke(instance, args);
 }       
 Span span = Trace.trace((TInfo) args[0], method.getName());
 try {   
    return method.invoke(instance, args);
 } catch (InvocationTargetException ex) {
   throw ex.getCause();
 } finally {
   span.stop();
 }       
{noformat}

  was:
One call ignores exceptions and one call handles exceptions.
{code}
if (args == null || args.length < 1 || args[0] == null || !(args[0] instanceof TInfo))
{
  return method.invoke(instance, args);
}       
Span span = Trace.trace((TInfo) args[0], method.getName());
try {   
  return method.invoke(instance, args);
} catch (InvocationTargetException ex) {
  throw ex.getCause();
} finally {
  span.stop();
}       
{code}


    
> Handle method.include calls consistently in TraceWrap class.
> ------------------------------------------------------------
>
>                 Key: ACCUMULO-845
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-845
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: David Medinets
>            Priority: Minor
>
> One call ignores exceptions and one call handles exceptions.
> {noformat}
>  if (args == null || args.length < 1 || args[0] == null || !(args[0] instanceof TInfo))
{
>   return method.invoke(instance, args);
>  }       
>  Span span = Trace.trace((TInfo) args[0], method.getName());
>  try {   
>     return method.invoke(instance, args);
>  } catch (InvocationTargetException ex) {
>    throw ex.getCause();
>  } finally {
>    span.stop();
>  }       
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message