accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Medinets (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-836) Specify Charset on getBytes() call for String objects.
Date Fri, 02 Nov 2012 13:15:11 GMT


David Medinets commented on ACCUMULO-836:

>One final statement, I still believe that in the ambiguous 
>cases where core classes read arbitrary bytes and write 
>UTF-8 bytes, Accumulo should be agnostic and not make 
>encoding assertions. In other words, I think we should revert 
>those changes and leave it up to the user to decide how they 
>handle their bytes.

If someone does revert the change, please add a comment about why no encoding is specified
so that future code reviews build on current knowledge.
> Specify Charset on getBytes() call for String objects.
> ------------------------------------------------------
>                 Key: ACCUMULO-836
>                 URL:
>             Project: Accumulo
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: David Medinets
>            Assignee: David Medinets
>            Priority: Minor
>             Fix For: 1.5.0
>         Attachments:
> The comments on ACCUMULO-241 indicate that the build server might have a different default
Charset than computers used by developers. Therefore, some of the tests have different results
on different computers.
> Every getBytes call on a String object should specify the UTF8 Charset. Unfortunately
the codebase has nearly 1,800 getBytes calls.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message