accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Trost (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-482) Add a thrift proxy server
Date Thu, 08 Nov 2012 14:35:12 GMT


Jason Trost commented on ACCUMULO-482:

Some comments.  

1. First off, I think this is an excellent start.

2. If possible, I would recommend separating the thrift generated java code into a "proxy/src/main/gen-java/"
to ensure that this code is not hand modified.  I didn't notice any directories with similar
names anywhere in the accumulo codebase so this may not be a convention with this project,
but we've found that separating this code makes test coverage reporting easier.

3. I didn't see a method like this, but I think you should add a close_scanner(String cookie)
or scanner_close(String cookie) method so the scanner can be explicitly closed when not being
used.  You may also want to add some expiration mechanism as well so bad client code does
keep adding scanners and iterators to their respective Maps.  Google Guava has a Cache class
that makes this really easy.

4. in your scanner_next_k() function, I would recommend calling ret.setResults(new ArrayList<TKeyValue>())
right after "ret" is initialized.  This makes the client code not have to check whether results
are null before attempting to iterate through them.  This makes the client code easier to
write, IMO.

more comments to come as I play with this more...  Thanks.
> Add a thrift proxy server
> -------------------------
>                 Key: ACCUMULO-482
>                 URL:
>             Project: Accumulo
>          Issue Type: New Feature
>            Reporter: Sapan Shah
>            Assignee: Chris McCubbin
>         Attachments: accumulo482patch.diff
> Add a thrift proxy server to make integration with other languages besides Java a bit
easier.  This should work like

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message