Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8FE0C99D4 for ; Thu, 4 Oct 2012 14:23:48 +0000 (UTC) Received: (qmail 30989 invoked by uid 500); 4 Oct 2012 14:23:48 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 30933 invoked by uid 500); 4 Oct 2012 14:23:48 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 30897 invoked by uid 99); 4 Oct 2012 14:23:47 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Oct 2012 14:23:47 +0000 Date: Fri, 5 Oct 2012 01:23:47 +1100 (NCT) From: "Luke Brassard (JIRA)" To: notifications@accumulo.apache.org Message-ID: <165148782.151.1349360627835.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (ACCUMULO-498) Key.getColumnVisibility() should return a ColumnVisibility, not a Text MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469395#comment-13469395 ] Luke Brassard commented on ACCUMULO-498: ---------------------------------------- So it seems that a decision needs to be made about efficiency and really whether we want to give up speed or space. The speed sacrifice will only come when users want to get a ColumnVisibility directly. On the other hand, the space would get eaten whether or not the user cared about what type was passed back. I did look into the option of adding a set(byte[] expression) method to the ColumnVisibility class to allow for reuse and then allowing for the passing of a ColumnVisibility object into the getColumnVisibilityParsed() method. It seems like there's not much to be gained there since the main cost of creating that object and the associated tree will still be there. > Key.getColumnVisibility() should return a ColumnVisibility, not a Text > ---------------------------------------------------------------------- > > Key: ACCUMULO-498 > URL: https://issues.apache.org/jira/browse/ACCUMULO-498 > Project: Accumulo > Issue Type: Improvement > Components: client > Affects Versions: 1.4.0, 1.3.5 > Reporter: John Vines > Assignee: Luke Brassard > Priority: Trivial > Labels: newbie > Fix For: 1.5.0 > > Attachments: ACCUMULO-498.patch > > > Currently getColumnVisibility() returns a Text. This doesn't make a lot of sense, since all other methods dealing with column visibilities use the ColumnVisibility object. We should use that instead. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira