accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-498) Key.getColumnVisibility() should return a ColumnVisibility, not a Text
Date Wed, 03 Oct 2012 16:40:07 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468656#comment-13468656
] 

Keith Turner commented on ACCUMULO-498:
---------------------------------------

bq. I'm wondering if we want to keep the parsed cv floating around in the object so that way
constructing a Key and then getting the visibility doesn't require re-parsing

I would be hesitant to do this.  It could use a lot more memory.  ColumnVisibility stores
a parse tree of the expression.  In my experience, the overhead of objects in java is significant
for cases like this where a small amount of data is stored.  I would not be surprised if object
overhead doubled or tripled the memory used.  Could possibly use a weak reference or soft
reference to the parsed CV as a compromise between saving CPU and memory.
                
> Key.getColumnVisibility() should return a ColumnVisibility, not a Text
> ----------------------------------------------------------------------
>
>                 Key: ACCUMULO-498
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-498
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 1.4.0, 1.3.5
>            Reporter: John Vines
>            Assignee: Luke Brassard
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 1.5.0
>
>         Attachments: ACCUMULO-498.patch
>
>
> Currently getColumnVisibility() returns a Text. This doesn't make a lot of sense, since
all other methods dealing with column visibilities use the ColumnVisibility object. We should
use that instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message