accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Billie Rinaldi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-765) Compare 1.4 and 1.5 API
Date Tue, 25 Sep 2012 15:03:07 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462819#comment-13462819
] 

Billie Rinaldi commented on ACCUMULO-765:
-----------------------------------------

Definitely do not replace it.  Iterator options are no longer accessed separately from the
iterators themselves.  The methods
{code:java}
List<AccumuloIterator> getIterators(Configuration conf)
{code}
and
{code:java}
List<AccumuloIteratorOption> getIteratorOptions(Configuration conf)
{code}
have been replaced by
{code:java}
List<IteratorSetting> getIterators(Configuration conf)
{code}

I guess the name of the replacement method will have to change if we bring the other two back
as deprecated.  I almost think we don't have to bring them back because those methods are
all protected.  Even in classes that extend InputFormatBase the design pattern is not to access
those methods directly, but to use {code:java}void setupIterators(Configuration conf, Scanner
scanner){code} which pulls the iterator information from the Configuration and adds the iterators
to the Scanner.  But I won't argue if anyone thinks we should bring them back.
                
> Compare 1.4 and 1.5 API
> -----------------------
>
>                 Key: ACCUMULO-765
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-765
>             Project: Accumulo
>          Issue Type: Task
>            Reporter: Keith Turner
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> Before we release 1.5 we must run test/compat/diffAPI.pl and analyze 1.4 and 1.5 API
changes.
> I just ran it and saw alow of diffs.  This may be because of removal of deprecated methods.
 I am going to attempt to improve the script to show whats deprecated in 1.4. Also I may attempt
to make it produce a report that would be suitable to include with release notes.
> I did notice the following API change that is not due to deprecation.  Need to research
the other diffs.
> {noformat}
> diff -u diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance
> --- diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance  2012-09-17 09:53:11.156401640
-0400
> +++ diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance  2012-09-17 09:53:22.580387286
-0400
> @@ -18,6 +18,6 @@
>      public org.apache.accumulo.core.client.ZooKeeperInstance(java.util.UUID, java.lang.String,
int);
>      public org.apache.accumulo.core.conf.AccumuloConfiguration getConfiguration();
>      public static java.lang.String getInstanceIDFromHdfs(org.apache.hadoop.fs.Path);
> -    public static java.lang.String lookupInstanceName(org.apache.accumulo.core.zookeeper.ZooCache,
java.util.UUID);
> +    public static java.lang.String lookupInstanceName(org.apache.accumulo.fate.zookeeper.ZooCache,
java.util.UUID);
>      public void setConfiguration(org.apache.accumulo.core.conf.AccumuloConfiguration);
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message