Return-Path: <dev-return-19301-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id BC14E2004A0
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 16 Aug 2017 20:30:24 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id BA7361694DE; Wed, 16 Aug 2017 18:30:24 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 341B21694DD
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 16 Aug 2017 20:30:24 +0200 (CEST)
Received: (qmail 332 invoked by uid 500); 16 Aug 2017 18:30:21 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 307 invoked by uid 99); 16 Aug 2017 18:30:21 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Aug 2017 18:30:21 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 25A31E053D; Wed, 16 Aug 2017 18:30:19 +0000 (UTC)
From: milleruntime <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-292-accumulo@git.apache.org>
In-Reply-To: <git-pr-292-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...
Content-Type: text/plain
Message-Id: <20170816183020.25A31E053D@git1-us-west.apache.org>
Date: Wed, 16 Aug 2017 18:30:19 +0000 (UTC)
archived-at: Wed, 16 Aug 2017 18:30:24 -0000

Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/292#discussion_r133530036
  
    --- Diff: server/master/src/main/java/org/apache/accumulo/master/tableOps/Utils.java ---
    @@ -59,21 +57,16 @@ static void checkTableDoesNotExist(Instance instance, String tableName, Table.ID
           throw new AcceptableThriftTableOperationException(null, tableName, operation, TableOperationExceptionType.EXISTS, null);
       }
     
    -  static <T extends AbstractId> T getNextTableId(String tableName, Instance instance, Class<T> idClassType) throws AcceptableThriftTableOperationException {
    +  static String getNextTableId(String tableName, Instance instance) throws AcceptableThriftTableOperationException {
    --- End diff --
    
    Other than using the Function interface, this doesn't seem all that different from the reflection code that I just removed. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---