Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: ctubbsii <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-292-accumulo@git.apache.org>
In-Reply-To: <git-pr-292-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...
Content-Type: text/plain
Message-Id: <20170816002757.0FD9DF329A@git1-us-west.apache.org>
Date: Wed, 16 Aug 2017 00:27:57 +0000 (UTC)
archived-at: Wed, 16 Aug 2017 00:28:06 -0000

Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/292#discussion_r133334428
  
    --- Diff: core/src/test/java/org/apache/accumulo/core/client/impl/NamespaceTest.java ---
    @@ -0,0 +1,54 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.core.client.impl;
    +
    +import static org.junit.Assert.assertEquals;
    +
    +import org.junit.Test;
    +
    +/**
    + * Tests the Namespace ID class, mainly the internal WeakHashMap.
    + */
    +public class NamespaceTest {
    +
    +  @Test
    +  public void testWeakHashMapIncreases() {
    +    String namespaceString = "namespace-testWeakHashMapIncreases";
    +    Integer initialSize = Namespace.ID.cache.asMap().size();
    +    Namespace.ID nsId = Namespace.ID.of(namespaceString);
    +    assertEquals(initialSize + 1, Namespace.ID.cache.asMap().size());
    +    assertEquals(namespaceString, nsId.canonicalID());
    +  }
    +
    +  @Test
    +  public void testWeakHashMapNoDuplicates() {
    +    String namespaceString = "namespace-testWeakHashMapNoDuplicates";
    +    Integer initialSize = Namespace.ID.cache.asMap().size();
    +    Namespace.ID nsId = Namespace.ID.of(namespaceString);
    +    assertEquals(initialSize + 1, Namespace.ID.cache.asMap().size());
    +    assertEquals(namespaceString, nsId.canonicalID());
    +
    +    // ensure duplicates are not created
    +    Namespace.ID builtInNamespaceId = Namespace.ID.of("+accumulo");
    +    assertEquals(Namespace.ID.ACCUMULO, builtInNamespaceId);
    +    builtInNamespaceId = Namespace.ID.of("+default");
    +    assertEquals(Namespace.ID.DEFAULT, builtInNamespaceId);
    +    nsId = Namespace.ID.of(namespaceString);
    +    assertEquals(initialSize + 1, Namespace.ID.cache.asMap().size());
    +    assertEquals(namespaceString, nsId.canonicalID());
    +  }
    +}
    --- End diff --
    
    Could add a small test to ensure size decreases once strong refs go away. Might not be able to use `.size()` because Cache may not clean up immediately, but should be able to use `.stream().count()` to get an accurate size of remaining elements after GC.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---