accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikewalch <...@git.apache.org>
Subject [GitHub] accumulo pull request #293: ACCUMULO-4669 Use windowed statistics in RFile
Date Fri, 18 Aug 2017 19:57:29 GMT
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/293#discussion_r134035002
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java ---
    @@ -403,7 +402,8 @@ public void flushIfNeeded() throws IOException {
     
         private SampleLocalityGroupWriter sample;
     
    -    private SummaryStatistics keyLenStats = new SummaryStatistics();
    +    // Use windowed stats to fix ACCUMULO-4669
    +    private RollingStats keyLenStats = new RollingStats(2017);
    --- End diff --
    
    Why 2017 for window size?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message