accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...
Date Wed, 16 Aug 2017 00:27:57 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/292#discussion_r133333368
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/data/impl/KeyExtent.java ---
    @@ -173,9 +154,9 @@ public KeyExtent(Text flattenedExtent, Text prevEndRow) {
       public void setTableId(Table.ID tId) {
     
         if (tId == null)
    -      throw new IllegalArgumentException("null table name not allowed");
    +      throw new IllegalArgumentException("null table id not allowed");
    --- End diff --
    
    This could be `Objects.requiresNonNull(tId, "null table id not allowed")`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message