accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From billoley <...@git.apache.org>
Subject [GitHub] accumulo pull request #291: ACCUMULO-4693: Add instance-specific ProcessName...
Date Fri, 11 Aug 2017 12:29:30 GMT
Github user billoley commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/291#discussion_r132674184
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsSystemHelper.java
---
    @@ -16,20 +16,65 @@
      */
     package org.apache.accumulo.server.metrics;
     
    +import java.util.HashMap;
    +import java.util.Map;
    +
     import org.apache.hadoop.metrics2.MetricsSystem;
     import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem;
    +import org.apache.hadoop.metrics2.source.JvmMetrics;
    +import org.apache.hadoop.metrics2.source.JvmMetricsInfo;
     
     /**
      *
      */
     public class MetricsSystemHelper {
     
    +  private static Map<String,String> serviceNameMap = new HashMap<>();
    +  private static String processName = "Unknown";
    +
    +  static {
    +    serviceNameMap.put("master", "Master");
    +    serviceNameMap.put("tserver", "TabletServer");
    +    serviceNameMap.put("monitor", "Monitor");
    +    serviceNameMap.put("gc", "GarbageCollector");
    +    serviceNameMap.put("tracer", "Tracer");
    +    serviceNameMap.put("shell", "Shell");
    +  }
    +
    +  public static void configure(String application) {
    +    String serviceName = application;
    +    if (MetricsSystemHelper.serviceNameMap.containsKey(application)) {
    +      serviceName = MetricsSystemHelper.serviceNameMap.get(application);
    +    }
    +
    +    // a system property containing 'instance' can be used if more than one TabletServer
is started on a host
    +    String serviceInstance = "";
    +    if (serviceName.equals("TabletServer")) {
    +      for (Map.Entry<Object,Object> p : System.getProperties().entrySet()) {
    +        if (((String) p.getKey()).contains("instance")) {
    +          // get rid of all non-alphanumeric characters and then prefix with a -
    +          serviceInstance = "-" + ((String) p.getValue()).replaceAll("[^a-zA-Z0-9]",
"");
    --- End diff --
    
    No.  An underscore is added to the instance for the benefit of log filename formatting.
 In the last iteration, I just removed the underscore.   I think the number without underscore
looks more professional / less hack-ish when it shows up in the metrics repeatedly.  After
I genericized the property (probably a mistake), I added this to remove non alpha/digit characters.
 The leading dash I can take or leave.   (TabletServer-1 vs TabletServer1)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message