accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #289: ACCUMULO-4677 Sanitizing PathParam values in RES...
Date Wed, 09 Aug 2017 01:08:20 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/289#discussion_r132070673
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/trace/TracesResource.java
---
    @@ -77,12 +81,12 @@
        * Generates a trace summary
        *
        * @param minutes
    -   *          Range of minutes to filter traces
    +   *          Range of minutes to filter traces Min of 0 minutes, Max of 30 days
        * @return Trace summary in specified range
        */
       @Path("summary/{minutes}")
       @GET
    -  public RecentTracesList getTraces(@DefaultValue("10") @PathParam("minutes") int minutes)
throws Exception {
    +  public RecentTracesList getTraces(@DefaultValue("10") @PathParam("minutes") @Min(0)
@Max(2592000) int minutes) throws Exception {
    --- End diff --
    
    Ah, interesting. So, it looks like there's a jersey extension which implements the validation
for this API. Without the jersey-bean-validation, these are nothing more than ignored annotations.
I'm curious what dependencies that might bring in. I don't think it'll be too bad, but need
to be careful to include whatever we need in the assembly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message