accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #289: ACCUMULO-4677 Sanitizing PathParam values in RES...
Date Tue, 08 Aug 2017 23:07:33 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/289#discussion_r132053915
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tables/TablesResource.java
---
    @@ -65,6 +69,7 @@
     public class TablesResource {
     
       private static final TabletServerStatus NO_STATUS = new TabletServerStatus();
    +  private static final Pattern COMMA = Pattern.compile("(,|%2[cC])");
    --- End diff --
    
    Should not be doing any URL decoding here. This should already be URL-decoded by the framework.
This is double-decoding. Although that's probably okay here (because namespaces can't contain
commas), it's a bad precedent to set.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message