accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #289: ACCUMULO-4677 Sanitizing PathParam values in RES...
Date Tue, 08 Aug 2017 23:07:33 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/289#discussion_r132053484
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/problems/ProblemsResource.java
---
    @@ -96,9 +98,13 @@ public ProblemSummary getSummary() {
       public void clearTableProblems(@QueryParam("s") String tableID) {
         Logger log = LoggerFactory.getLogger(Monitor.class);
         try {
    +      tableID = ParameterValidator.sanitizeParameter(tableID);
    +      if (StringUtils.isEmpty(tableID)) {
    --- End diff --
    
    Probably not worth bringing in StringUtils for simple `s == null || s.isEmpty()` checks.
More use of commons-lang means more possible points of breakage with transitive dependencies.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message