accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #289: ACCUMULO-4677 Sanitizing PathParam values in RES...
Date Tue, 08 Aug 2017 23:07:33 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/289#discussion_r132053160
  
    --- Diff: server/monitor/pom.xml ---
    @@ -45,6 +45,10 @@
           <artifactId>javax.servlet-api</artifactId>
         </dependency>
         <dependency>
    +      <groupId>javax.validation</groupId>
    +      <artifactId>validation-api</artifactId>
    --- End diff --
    
    This is interesting. What does the enforcement of these annotations?
    
    Also, if this is used, it should be added to the binary tarball (`assemble/src/main/assemblies/component.xml`
and `assemble/pom.xml`), as well as the root `pom.xml`'s `<dependencyManagement>` section
with a `<version>`. It's AL2 licensed, and no NOTICE file, and has no dependencies,
so IP is pretty simple to deal with if we go this direction.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message