accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <...@git.apache.org>
Subject [GitHub] accumulo pull request #289: ACCUMULO-4677 Sanitizing PathParam values in RES...
Date Fri, 04 Aug 2017 16:19:57 GMT
Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/289#discussion_r131427513
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tservers/TabletServerResource.java
---
    @@ -141,28 +146,27 @@ public TabletServersRecovery getTserverRecovery() {
       /**
        * Generates details for the selected tserver
        *
    -   * @param tserverAddr
    +   * @param tserverAddress
        *          TServer name
        * @return TServer details
        */
       @Path("{address}")
       @GET
    -  public TabletServerSummary getTserverDetails(@PathParam("address") String tserverAddr)
throws Exception {
    -
    -    String tserverAddress = tserverAddr;
    +  public TabletServerSummary getTserverDetails(@PathParam("address") String tserverAddress)
throws Exception {
    --- End diff --
    
    +1 I prefer full english words for parameter variable names (especially with Strings).
 Unless you are using VIM as your IDE, abbreviation doesn't help anyone and only leads to
confusion.  Granted, this example 99% of developers will know what "addr" means but who knows...
there could be another variable to come along with the name tserverAdder or something. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message