Return-Path: <dev-return-19183-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id B8354200CE1
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 28 Jul 2017 00:39:41 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id B662A16B54A; Thu, 27 Jul 2017 22:39:41 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 2EC6216B53B
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 28 Jul 2017 00:39:41 +0200 (CEST)
Received: (qmail 69730 invoked by uid 500); 27 Jul 2017 22:39:40 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 69719 invoked by uid 99); 27 Jul 2017 22:39:40 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Jul 2017 22:39:40 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 057D7E02FE; Thu, 27 Jul 2017 22:39:40 +0000 (UTC)
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-283-accumulo@git.apache.org>
In-Reply-To: <git-pr-283-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #283: ACCUMULO-4687 Clean up some static-analysis warn...
Content-Type: text/plain
Message-Id: <20170727223940.057D7E02FE@git1-us-west.apache.org>
Date: Thu, 27 Jul 2017 22:39:40 +0000 (UTC)
archived-at: Thu, 27 Jul 2017 22:39:41 -0000

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/283#discussion_r129976474
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/BasicServlet.java ---
    @@ -264,4 +264,12 @@ protected static void banner(StringBuilder sb, String klass, String text) {
         sb.append("<br />\n<h2 class='").append(klass).append("'>").append(text).append("</h2>\n");
       }
     
    +  /**
    +   * Creates a {@link Cookie} with the given name and value, also setting the HttpOnly attribute on the cookie.
    +   */
    +  protected static Cookie createCookie(String name, String value) {
    +    Cookie c = new Cookie(name, value);
    +    c.setHttpOnly(true);
    --- End diff --
    
    > I can double-check, but I'm not aware of that in 1.x. Not sure how the table sorting stuff works.
    
    So I'm surprised, but this actually just doesn't break anything. Sorting on tables still works. Returning to a page after leaving retains the sort column+order.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---